Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double pagination of Chains #1253

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Double pagination of Chains #1253

merged 2 commits into from
Oct 8, 2024

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Oct 8, 2024

Summary

The current max_limit/default_limit of Chains pagination is 20. However, we now have 21 chains configured on prod. As such, this doubles the max_limit/default_limit to 40.

Note: the max_limit was previously reduced from 100. We should investigate why there is a limit and whether we can safely remove it (like Safe Apps). If we were to remove it, we would need to create a v2 endpoint as returns the results directly.

Changes

  • Set max_limit/default_limit to 40
  • Update tests accordingly

@iamacook iamacook self-assigned this Oct 8, 2024
@iamacook iamacook requested a review from a team as a code owner October 8, 2024 12:52
@coveralls
Copy link

coveralls commented Oct 8, 2024

Pull Request Test Coverage Report for Build 11236386192

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.501%

Totals Coverage Status
Change from base Build 11234294847: 0.0%
Covered Lines: 1197
Relevant Lines: 1203

💛 - Coveralls

@iamacook iamacook changed the title Double max_limit of Chains pagination Double pagination of Chains Oct 8, 2024
@iamacook iamacook merged commit a2c2c31 into main Oct 8, 2024
17 checks passed
@iamacook iamacook deleted the increase-max-limit branch October 8, 2024 13:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants