fix(safe-apps-provider): fallback value and data were overwritten…

… with `undefined` (#530)
safe-global · Dec 11, 2023 · d6baa64 · d6baa64
1 parent 53bd4a8
commit d6baa64
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/.changeset/hungry-lizards-obey.md b/.changeset/hungry-lizards-obey.md
@@ -0,0 +1,5 @@
+---
+'@safe-global/safe-apps-provider': patch
+---
+
+fallback `value` and `data` were overwritten with `undefined`
diff --git a/packages/safe-apps-provider/dist/provider.js b/packages/safe-apps-provider/dist/provider.js
diff --git a/packages/safe-apps-provider/dist/provider.js.map b/packages/safe-apps-provider/dist/provider.js.map
diff --git a/packages/safe-apps-provider/src/provider.ts b/packages/safe-apps-provider/src/provider.ts
@@ -81,10 +81,11 @@ export class SafeAppProvider extends EventEmitter implements EIP1193Provider {
       }
 
       case 'eth_sendTransaction':
+        // `value` or `data` can be explicitly set as `undefined` for example in Viem. The spread will overwrite the fallback value.
         const tx = {
-          value: '0',
-          data: '0x',
           ...params[0],
+          value: params[0].value || '0',
+          data: params[0].data || '0x',
         };
 
         // Some ethereum libraries might pass the gas as a hex-encoded string