Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper PostgreSQL support #825

Merged
merged 22 commits into from
Apr 29, 2016
Merged

Proper PostgreSQL support #825

merged 22 commits into from
Apr 29, 2016

Conversation

evert
Copy link
Member

@evert evert commented Apr 27, 2016

This is a new version of PR #521. I started from scratch but used #521 for inspiration.

Tackling PostGres one unittest at a time.

Fixes #804

@evert evert self-assigned this Apr 27, 2016
@evert evert added this to the 3.2 milestone Apr 27, 2016
@evert evert mentioned this pull request Apr 27, 2016
@evert
Copy link
Member Author

evert commented Apr 28, 2016

The work for this is functionally done. Everything works, everything is tested locally. We will only support postgres 9.5.

Two steps are still left:

  1. I need to tell travis somehow to install postgres 9.5
  2. I want the unit test suite to automatically skip tests if we're connected to a postgres server that is older than 9.5.

After that, this can be merged.

@evert
Copy link
Member Author

evert commented Apr 29, 2016

Looks like there's currently not a sane way to enable postgres 9.5 in travis. So I'm leaving those tests skipped for now. All tests pass locally though, so postgres support is completed!

@evert evert merged commit 94ae901 into master Apr 29, 2016
@evert evert deleted the postgres branch April 29, 2016 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant