Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for multiple labels with the same starting letter on changes.meta #10

Merged
merged 28 commits into from
Feb 15, 2023
Merged

Allow for multiple labels with the same starting letter on changes.meta #10

merged 28 commits into from
Feb 15, 2023

Conversation

joao-paulo-parity
Copy link
Contributor

@joao-paulo-parity joao-paulo-parity commented Feb 10, 2023 •
edited
Loading

  • Changes the format of changes.meta such that multiple labels with the same starting letter are taken into account (related to Handle non mutually-exclusive labels #9)
    Check out the new format in the diff of test/test_meta.rb
  • Pulls compute_change_meta and parse_change_label out of Changelogerator so that they can be unit-tested easily
  • Make it possible to run unit tests locally in the absence of $GITHUB_TOKEN

I added some instructions for how to try this out in paritytech/polkadot#6702

closes #9

@joao-paulo-parity joao-paulo-parity mentioned this pull request Feb 10, 2023
Merged
@joao-paulo-parity joao-paulo-parity mentioned this pull request Feb 10, 2023
Merged
joao-paulo-parity and others added 23 commits February 14, 2023 07:33
@joao-paulo-parity
re-add comment on compute_change_meta
7f95009
@joao-paulo-parity
refactor $GITHUB_TOKEN checks
fcbd198
@joao-paulo-parity
refactor $GITHUB_TOKEN checks
9341786
@chevdor
bump version to 3.0.5 and add MFA
a066bd7
@chevdor
Extract a Label class and add some tests
1439f0d
@chevdor
Add error handling
879d391
@chevdor
Avoid skipping tests that could run
7934dbf
@joao-paulo-parity
set GITHUB_TOKEN=disabled for pull requests on CI
c5942aa
@joao-paulo-parity
Merge branch 'jp/meta' of github.com:paritytech/changelogerator into …
a3c3567 
…jp/meta
@joao-paulo-parity
fix if expression
1577956
@joao-paulo-parity
fix if expression
ec43e6a
@chevdor
Fix readme
0906060
@chevdor
Remove some polkadot/srtool specifics
54770bd
@joao-paulo-parity
update README example
140602d
@joao-paulo-parity
Merge branch 'jp/meta' of github.com:paritytech/changelogerator into …
ecc0826 
…jp/meta
@joao-paulo-parity
improve comments
4cbf9d6
@chevdor
Add new test
27d21e2
@chevdor
Refactoring for better irb support
d3be4b3
@chevdor
Fix so both local and online tests work
85a1710
@chevdor
Add new flag to return the version
c905262
@chevdor
Fix packaging
0de7e51
@joao-paulo-parity
disable lint
fb98671
@chevdor
Fix location of the gemspec
9315a1c
@chevdor chevdor self-requested a review February 15, 2023 17:07
@chevdor chevdor merged commit e064ce1 into s3krit:master Feb 15, 2023
@chevdor chevdor deleted the jp/meta branch February 15, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chevdor chevdor chevdor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle non mutually-exclusive labels
2 participants
@joao-paulo-parity @chevdor