eth/filters: fix blockHash in eth_getfilterchanges (ethereum#208)

s1na · Aug 31, 2023 · 9e860e4 · 9e860e4
1 parent 02158d0
commit 9e860e4
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/eth/filters/api.go b/eth/filters/api.go
@@ -28,6 +28,7 @@ import (
 	ethereum "github.com/XinFinOrg/XDPoSChain"
 	"github.com/XinFinOrg/XDPoSChain/common"
 	"github.com/XinFinOrg/XDPoSChain/common/hexutil"
+	"github.com/XinFinOrg/XDPoSChain/core"
 	"github.com/XinFinOrg/XDPoSChain/core/types"
 	"github.com/XinFinOrg/XDPoSChain/ethdb"
 	"github.com/XinFinOrg/XDPoSChain/event"
@@ -418,6 +419,10 @@ func (api *PublicFilterAPI) GetFilterChanges(id rpc.ID) (interface{}, error) {
 		case LogsSubscription:
 			logs := f.logs
 			f.logs = nil
+			for _, log := range logs {
+				// update BlockHash to fix #208
+				log.BlockHash = core.GetCanonicalHash(api.chainDb, log.BlockNumber)
+			}
 			return returnLogs(logs), nil
 		}
 	}