This repository was archived by the owner on Dec 1, 2019. It is now read-only.
Fix custom transformers when using fork checker #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using forked checker mode, it's impossible to pass a custom function to the checker via the options as it's a different process. To get around this, we can pass a path to the module that is then exceuted once the checker is initialized.
|
Thank you, I'll look through it |
|
@s-panferov, what's the kind word? I can look at the CI failure on 2.5.3. |
This was referenced Mar 8, 2018
|
@s-panferov @guncha The following line is removed in the following commit immediately after this PR was merged. 38a772f#diff-de66cf07555cd70991f012b02db0bd52L432 Is this really working? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something that we've been using for the past half a year and I thought it'd be good to get it in upstream. Fixes #447.
I guess this does the same thing as this other PR (closes #423) except we're not introducing a new config. If the
getCustomTransformersis a string, it's assumed to be a module that can be simply required so either something that can be found in the parentnode_modulesor an absolute module path. If it's a function, then the code works as before.Another difference is that the function is not given the Program object. I don't know how useful this is or not, but it can be easily added.
Let me know if you need me to do anything else for this. Probably a test or two would be in order.