Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_procs should warn rather than erroring if a proc with a duplicate name is loaded #59

Closed
FishmanL opened this issue Feb 2, 2021 · 3 comments · Fixed by #60
Closed

Comments

@FishmanL
Copy link
Contributor

FishmanL commented Feb 2, 2021

in particular my blueprint registration is idempotent in other ways, so it might be getting run twice -- any chance of a silent failure on load_procs?

@ryanhiebert
Copy link
Owner

I guess I'd probably be fine with a warning instead of an error. If I were looking at your code, I'd probably want to figure out why I need to register the procs multiple times, though. That seems less than ideal.

@ryanhiebert
Copy link
Owner

A pull request would be welcome. I'm unlikely to write this up myself.

FishmanL added a commit to FishmanL/hirefire that referenced this issue Feb 2, 2021
@FishmanL
Copy link
Contributor Author

FishmanL commented Feb 2, 2021

Done! (The short answer for idempotency is 'our blueprint registration is complicated and multipathed, and somewhere in there is a small bug that I do want to fix eventually')

ryanhiebert pushed a commit that referenced this issue Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants