Skip to content

Commit

Permalink
Ray TPU Webhook Autoscaling Support (GoogleCloudPlatform#740)
Browse files Browse the repository at this point in the history
* Generate hostnames at Pod creation

Signed-off-by: Ryan O'Leary <[email protected]>

* Should not fatal log in deletePod

Signed-off-by: Ryan O'Leary <[email protected]>

* deletePod admission always succeeds

Signed-off-by: Ryan O'Leary <[email protected]>

* Remove unused tests make command

Signed-off-by: Ryan O'Leary <[email protected]>

* Update tests and add error checking

Signed-off-by: Ryan O'Leary <[email protected]>

* Just return an error instead of logging

Signed-off-by: Ryan O'Leary <[email protected]>

---------

Signed-off-by: Ryan O'Leary <[email protected]>
  • Loading branch information
ryanaoleary committed Jul 19, 2024
1 parent c9c6371 commit ec7207a
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion ray-on-gke/tpu/kuberay-tpu-webhook/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ func extractRayCluster(admissionReview *admissionv1.AdmissionReview) (*ray.RayCl
func genDNSHostnames(numOfHosts int32, groupName string, clusterName string, namespace string, replicaIndex int) (string, error) {
if numOfHosts == 0 {
err := errors.New("workerGroupSpec NumOfHosts not set")
klog.ErrorS(err, "genDNSHostnames", "RayCluster", namespace+"/"+clusterName, "NumOfHosts", numOfHosts)
return "", err
}
hostNames := make([]string, numOfHosts)
Expand Down

0 comments on commit ec7207a

Please sign in to comment.