fixes #7 #12
fixes #7 #12
Conversation
|
@alunny, this change is supposed to fix the plugin for Windows env. I want to make sure it doesn't break it for you. Could you please check? Thanks |
|
@rxaviers I'm not the OP, but can confirm this works for me on WIndows (and is required in order to get webpack building with Globalize). |
|
Thank you @flipchart, I want to make sure it doesn't break other envs (which I guess it won't). I plan to merge this PR soon. Just finding time to do this final review. |
|
Thanks @rxaviers, will confirm today. |
| @@ -5,7 +5,7 @@ var path = require("path"); | |||
| var mainFiles = ["ca-gregorian", "currencies", "dateFields", "numbers", "timeZoneNames", "units"]; | |||
|
|
|||
| var isGlobalizeModule = function(filepath) { | |||
| filepath = filepath.split( "/" ); | |||
| filepath = filepath.split( /[\/\\]/ ); | |||
There was a problem hiding this comment.
You can use path.sep in node to get the platform specific file separator (a bit of a pain with some of the regex literals in this diff though).
|
Diff works with our app, thanks for the PR @aruberto :) |
|
I can also confirm that the fix works. @rxaviers Any chance to get this merged and released in the near future? IMHO it is more or less a critical bug... |
|
Thank you @aruberto and everyone that checked this fix. |
|
Released as |
|
wow, that was amazingly fast! Thanks!!! |
No description provided.