Rework project structure and change build system to CMake (alias OV3) #58

mhthies · 2021-07-09T12:16:04Z

Change summary:

All makefiles have been removed, as well as the old "acplt_makmak" makefile generator. Instead, CMake is used for makefile generation. All components of the RTE and OV libraries have been transformed to CMake targets and some magic has been applied to handle code generation from .ovm files (through ov_codegen)
- no hard to maintain build script anymore
- No boilerplate code for OV libraries anymore
- statically linked builds work automagically now
- cross-compilation is easily possible and extensible now
- building with MSVC is working (and demonstrated by GitHub Actions CI)
- downside: Building OV libraries requires OV build and building OV locally
"Addon libs" have been removed from core project and moved to "library projects", which can be included in application-specific projects in a modular way (e.g. as Git submodules)

Superseds and thus closes #53

now marking unaccessable undefined and defined memory regions

added valgrind leak check for database added valgrind pool management int tlsf added printing of database pointers changed defines for building with valgrind integration remove test executable

changed: redirect for database malleoc/realloc/free now with vendortree variable changed: OV_VALGRIND now enabled by default for debub builds in linux fixed: double frees for part objects when marking database pointer freed

string list for headers not freed own port in httpmanager reset on restart temporary any variables not freed in setvar

free all adressInfoElements on shutdown avoid execution startup for aresWorker on server restart

freeing OwnPort variable of xdrmanager on shutdown

parts of database are marked as noaccess but that is ok

add branch name to release name

fixed double use of iterator variable

…cture

* Remove "libov/" prefix * don't include ov_debug.h within ov_ov.h to avoid dependency of ovheaders on ov

This is a dirty hack and should be replaced by an additional header only library for the ks types in the future.

Instead, -c is a short form of --create now, which allows to create the database file, while specifying the database size (as it does with dbutil). This is a breaking change to ov_runtimeserver's command line options

... and fix a related bug in UDPbind

moving the database caused vector variables to be set to 0 length this only occured in debug builds and only when loading an existing database

This commit does not intend to result in any legal changes. It's sole purpose is to clarify the license conditions and improve compliance with filename and formulation conventions.

Improve cmake build See merge request acplt/rte-tools/rte!4

Resolved Conflicts: deleted addonlibs/functionblock/iec61131stdfb/source/CONCATVEC.c deleted tools/travis_createDoc_and_handlerepos.sh

mhthies · 2021-07-09T12:18:17Z

Documentation of new build system usage and intended project structure can be found in the reworked README file.

We are currently waiting for some internal tests with a large OV application project to verify the operability of the "new" OV build.

HolgerJeromin · 2021-07-09T13:16:58Z

You could add closes #53 in the first comment to close the superseded PR #53 on merge.

* add python file with base services and some additonal functionality * add example script on how to use this tool

tools/kshttp-pyhton/vdivde.py

HolgerJeromin · 2021-07-23T11:15:48Z

tools/kshttp-pyhton/vdivde.py

+    s = server_by_name(server_name, host=host)
+
+    # fix vdivde3696 timer
+    if object_exists(s, '/acplt/vdivde3696'):


Do not hard code that path.
You can iterate over all libraries instantiations of
/acplt/ov/library (this one is really fixed)

https://github.com/acplt/rte/blob/02f9eb1e42a1a42216e312fd971653a9f9e7f46e/addonlibs/hmi/hmiJavaScript/JavaScript/hmi-class-HMIJavaScriptKSClient.js#L1067

Since this is only a script for quick-fixing some of the real-life issues resulting from the fix in #60, I consider it okay that this script takes the short cut, which may not be 100% correct but sufficient in most cases. It should be used with care anyhow.

Than at least add a comment.

…tion

* replace format constants with enum value * change print_instance_counts to resolve library via ov/library.instance * bug fixes

* actually process the queue in get_all_subclasses * remove some debug otput

… into it

LarsNt and others added 30 commits June 6, 2019 10:39

added tlsf valgrind integration test executable

be5418e

added valgrind memory access management to tlsf

9629609

now marking unaccessable undefined and defined memory regions

finished valgrand integtation for tlsf

38e7786

added valgrind leak check for database added valgrind pool management int tlsf added printing of database pointers changed defines for building with valgrind integration remove test executable

changed database allocator redirects for valgrind

e367b38

changed: redirect for database malleoc/realloc/free now with vendortree variable changed: OV_VALGRIND now enabled by default for debub builds in linux fixed: double frees for part objects when marking database pointer freed

added valgrind to travis dependencies

680aa7f

memleak fix in kshttp

1b44616

string list for headers not freed own port in httpmanager reset on restart temporary any variables not freed in setvar

memleak fix for TCPBind

7cd386d

free all adressInfoElements on shutdown avoid execution startup for aresWorker on server restart

memleak fix for ksxdr

62c3d79

freeing OwnPort variable of xdrmanager on shutdown

fix valgrind warning on database flush

98d8b18

parts of database are marked as noaccess but that is ok

changed travis scripts

238e762

add branch name to release name

fixed setvar for vectors and multiple variables in kshttp

33cbae1

fixed double use of iterator variable

runtimeserver: Improve error reporting

aa8b8c8

tools: Add Python script to plot library dependencies

8b55f99

Delete legacy code, libraries to be moved to own project, rework stru…

56fe397

…cture

Fix includes for new project structure

3a2adbe

* Remove "libov/" prefix * don't include ov_debug.h within ov_ov.h to avoid dependency of ovheaders on ov

Remove more legacy files, restructure docs, improve prebuild scripts

7eb52ac

Add new CMake based build system (first draft)

2fe9a02

kshist: Add dependency on ksbase to fix compilation

a7678c7

This is a dirty hack and should be replaced by an additional header only library for the ks types in the future.

Adapt README for new build system

593fd43

UDPbind: Convert line endings to Unix style to fix build

6346719

ov_codegen: Improve documentation

dffb300

TCPbind: Fix linker flags in CMakeLists

e818f72

tools: Add Python script to plot library dependencies

4f88c7a

ov_options: Drop legacy -c cli option alias for --config

b45ffed

Instead, -c is a short form of --create now, which allows to create the database file, while specifying the database size (as it does with dbutil). This is a breaking change to ov_runtimeserver's command line options

fb: Remove legacy licence checking code and fix compiler warnings

a47d226

cmake: Set -DPLT_USE_WINSOCK2=1 globally

aaa67fb

ksbase: Enable KS logging of errors and warnings

5892cc3

... and fix a related bug in UDPbind

opcua: Tidy up compile definitions and fix compiler warnings

b384408

ksbase: Fix compiler warnings about truncated log messages

caa3601

ov: Add cmake option for OV_VALGRIND

0ecc253

LarsNt and others added 15 commits May 28, 2021 10:37

cmake: set c standard for acplt_builder

5d575ae

cmake: add build option for acplt_builder and ov_dbutil

b1b9254

ov: fix bug that deletes vectors on server restarts

ac70e11

moving the database caused vector variables to be set to 0 length this only occured in debug builds and only when loading an existing database

Don't use -Wall flag with MSVC

a79e24e

cmake: Fix compiler detection to consider C compiler

ec77483

readme: Add links to other projects on GitHub

1adca3c

Add GitHub Actions CI build workflow

4fc0632

ci: Improve GitHub workflow: Use GITHUB_PATH for installing WinFlexBison

4a0191d

add gitignore for generated source templates

ad0f1e1

readme: fix some spelling mistakes

4571959

Improve license information, add full text of License

72c2f15

This commit does not intend to result in any legal changes. It's sole purpose is to clarify the license conditions and improve compliance with filename and formulation conventions.

readme: Fix example application project CMake script

fd93739

Merge branch 'cmake_fixes' into 'ov3'

9a6a53e

Improve cmake build See merge request acplt/rte-tools/rte!4

Merge branch 'develop' into ov3 as preparation for merging ov3

a217547

Merge branch 'master' into ov3 as preparation for merging ov3

292c683

Resolved Conflicts: deleted addonlibs/functionblock/iec61131stdfb/source/CONCATVEC.c deleted tools/travis_createDoc_and_handlerepos.sh

readme: Add 'Clients' section

735a4a0

mhthies marked this pull request as ready for review July 19, 2021 06:35

add tool for kshttp in python

301aad9

* add python file with base services and some additonal functionality * add example script on how to use this tool

HolgerJeromin reviewed Jul 23, 2021

View reviewed changes

tools/kshttp-pyhton/vdivde.py Outdated Show resolved Hide resolved

HolgerJeromin reviewed Jul 23, 2021

View reviewed changes

mhthies and others added 6 commits July 29, 2021 16:59

tool: Fix directory name of kshttp-python

3e7193f

readme: Mention kshttp-python tool as an incomplete client implementa…

06784b1

…tion

add python script to generate new library templates

a6422a9

improvements to kshttp-python script

6220768

* replace format constants with enum value * change print_instance_counts to resolve library via ov/library.instance * bug fixes

add additional comments to vdivde example script

062c975

fix bugs in kshttp-python

531df16

* actually process the queue in get_all_subclasses * remove some debug otput

mhthies merged commit cd6044b into master Aug 23, 2021

mhthies added a commit that referenced this pull request Aug 23, 2021

Merge branch 'ov3' (PR #58) again, since #60 and #61 have been merged…

e34398c

… into it

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rework project structure and change build system to CMake (alias OV3) #58

Rework project structure and change build system to CMake (alias OV3) #58

mhthies commented Jul 9, 2021 •

edited

Loading

mhthies commented Jul 9, 2021

HolgerJeromin commented Jul 9, 2021

HolgerJeromin Jul 23, 2021

mhthies Jul 29, 2021

HolgerJeromin Jul 29, 2021

Rework project structure and change build system to CMake (alias OV3) #58

Rework project structure and change build system to CMake (alias OV3) #58

Conversation

mhthies commented Jul 9, 2021 • edited Loading

mhthies commented Jul 9, 2021

HolgerJeromin commented Jul 9, 2021

HolgerJeromin Jul 23, 2021

Choose a reason for hiding this comment

mhthies Jul 29, 2021

Choose a reason for hiding this comment

HolgerJeromin Jul 29, 2021

Choose a reason for hiding this comment

mhthies commented Jul 9, 2021 •

edited

Loading