Replace resolve.sync() with require.resolve()
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`resolve.sync()` resolves starting from the current working directory, but we actually would want to resolve these dependencies from `__dirname` since they are *our* dependencies, not the ones from the host app. `require.resolve()` correctly resolves using `__dirname` as the base path. This change will also make this project compatible with Yarn PnP, as it was previously complaining about `pretender` not being a declared dependency of the host app.
|
ember-cli-pretender 3.1.0 published 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve.sync()resolves starting from the current working directory, but we actually would want to resolve these dependencies from__dirnamesince they are our dependencies, not the ones from the host app.require.resolve()correctly resolves using__dirnameas the base path.This change will also make this project compatible with Yarn PnP, as it was previously complaining about
pretendernot being a declared dependency of the host app.