Allow opt-out of fetch polyfill #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could also use the browser targets to decide if it is needed... |
|
I can implement the same changes as here: ember-cli/ember-fetch#173 ? |
rwjblue
approved these changes
Jan 18, 2019
|
ember-cli-pretender 3.1.0 published 🎉 |
xg-wang
reviewed
Feb 17, 2019
| @@ -35,6 +35,16 @@ var app = new EmberApp({ | |||
| }); | |||
| ``` | |||
|
|
|||
| You can also opt out of including the fetch polyfill, if you do not need to run your tests in older browsers: | |||
There was a problem hiding this comment.
Should this be "if you do not need to test fetch with pretender"? Since the polyfill is not for older browsers but to make fetch interceptable by pretender.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
includeFetchPolyfillconfiguration option, which defaults to true, but can be disabled to not include the fetch polyfill.IMHO, it would make sense to default this to
false, and make this opt-in instead - but that would be a breaking change for a major release.Fixes #66