Issue manager refactor #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwblair
approved these changes
May 25, 2022
rwblair
pushed a commit
that referenced
this pull request
Nov 7, 2024
chore: Prepare for publication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rwblair Here's some of what I'd been playing around with merged with your entities branch for issues. Let me know what you think.
This attempts to keep the old issue types around as close as possible, creating a manager class for it with an add method that accepts some other variants of file data (such as BIDSFile objects from the context with or without additional fields to populate the issue). It might be cleaner to just require the extra fields when passed in but still support the raw structure from the existing validator.
One other change I might make is making some of the issue fields more optional but I should figure out which ones were optional in the existing issues output better first.
Also adds some type fixes and no-check annotations so this now runs without
--no-checkfor both tests and validation.