forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LLVM][XTHeadVector] Add RedundantVSETVLIElimination
pass to remove unnecessary vtype-preserving sequences
#99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
043953b
to
e29122e
Compare
<backup-vtype>-<action>-<restore-vtype>
where <action>
has no side effiectRedundantVSETVLIElimination
pass to remove unnecessary vtype-preserving sequences
e29122e
to
07b6431
Compare
This pass removes code sequences like: ``` csrr <r1>, vl csrr <r2>, vtype <a lot of th.vsetvl/th.vsetvli> th.vsetvl zero, <r1>, <r2> ```
07b6431
to
4c99a7e
Compare
Let's wait for CI results 😉 |
imkiva
added a commit
to imkiva/llvm-project
that referenced
this pull request
Feb 24, 2025
… unnecessary vtype-preserving sequences (ruyisdk#99) * [LLVM][XTHeadVector] Initial `RedundantVSETVLIElimination` pass * [LLVM][XTHeadVector] `RedundantVSETVLIElimination` This pass removes code sequences like: ``` csrr <r1>, vl csrr <r2>, vtype <a lot of th.vsetvl/th.vsetvli> th.vsetvl zero, <r1>, <r2> ``` * [LLVM][XTHeadVector] Update tests * [LLVM][XTHeadVector] Update tests * [LLVM][XTHeadVector] Fix comments * [LLVM][XTHeadVector] Fix comments * [LLVM][XTHeadVector] More comments * [LLVM][XTHeadVector] Update tests * [LLVM][XTHeadVector] add option `riscv-enable-vsetvli-elim`
imkiva
added a commit
to imkiva/llvm-project
that referenced
this pull request
Feb 26, 2025
… unnecessary vtype-preserving sequences (ruyisdk#99) * [LLVM][XTHeadVector] Initial `RedundantVSETVLIElimination` pass * [LLVM][XTHeadVector] `RedundantVSETVLIElimination` This pass removes code sequences like: ``` csrr <r1>, vl csrr <r2>, vtype <a lot of th.vsetvl/th.vsetvli> th.vsetvl zero, <r1>, <r2> ``` * [LLVM][XTHeadVector] Update tests * [LLVM][XTHeadVector] Update tests * [LLVM][XTHeadVector] Fix comments * [LLVM][XTHeadVector] Fix comments * [LLVM][XTHeadVector] More comments * [LLVM][XTHeadVector] Update tests * [LLVM][XTHeadVector] add option `riscv-enable-vsetvli-elim`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #38 we generated prologue and epilogue for COPY nodes, which looks like:
After pass
RedundantCopyElimination
, some<COPY-node>
will be removed from the basic block, thus the sequence becomes:And this PR added a new pass
RedundantVSETVLIElimination
to remove the above sequence pattern.NOTE: this PR is based on #98, so it should be merged before this one 😉
/cc @AinsleySnow