refactor: Use PBAR.warn and a struct for versions #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in rustwasm#409, some comments mentioned to use `?` over calling `.unwrap()` and to use a struct instead of two Strings. This PR leverages `?` and a new struct called `WasmPackVersion` with a `local` and `latest` field. This PR also uses `PBAR.warn(warning_msg)` instead of `println!(warning_msg)` to print the warning message.
alexcrichton
approved these changes
Apr 15, 2019
ashleygwilliams
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #409, some comments mentioned to use
?over calling.unwrap()and to use a struct instead of two Strings. This PR leverages?and a new struct calledWasmPackVersionwith alocalandlatestfield. This PR also usesPBAR.warn(warning_msg)instead ofprintln!(warning_msg)to print the warning message. I also changed
which::which("wasm-pack")toenv::current_exe().