Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move binary installation to it's own crate #415

Merged
merged 24 commits into from
Dec 28, 2018

Conversation

drager
Copy link
Member

@drager drager commented Oct 15, 2018

This PR intends to fix #384.

@ashleygwilliams
Copy link
Member

hey @drager looks like this needs a rebase- i've been holding off reviewing because it says WIP- what's the status here? would love to get this merged soon!

@ashleygwilliams ashleygwilliams added this to the 0.6.0 milestone Oct 29, 2018
@drager
Copy link
Member Author

drager commented Oct 29, 2018

@ashleygwilliams Status is that I'm having some problems with cargo workspaces for the tests. Running cargo test results in some failures because of the workspaces. I get the following output that makes the tests fail: current package believes it's in a workspace when it's not.

However, if I remove the [workspace] section the tests pass...

I'm hoping to resolve this as soon as possible and then add some tests for the functions in the binary_installation crate.

@drager
Copy link
Member Author

drager commented Oct 29, 2018

@ashleygwilliams: I have now resolved the issue with workspaces and I added some tests for the path functions as well.

I suppose you could review the code I have pushed now. However, I think some more tests could be added. Please let me know what you think. 😊

@fitzgen
Copy link
Member

fitzgen commented Oct 30, 2018

@drager heads up: if you rebase, then appveyor CI should be fixed 👍

@drager
Copy link
Member Author

drager commented Oct 30, 2018

@fitzgen: Thank you! 😊

@drager drager changed the title [WIP] refactor: Move binary installation to it's own crate refactor: Move binary installation to it's own crate Oct 30, 2018
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
binary-install/Cargo.toml Outdated Show resolved Hide resolved
binary-install/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will work on fixing the merge conflict- this looks good to me! thanks so much!

@drager
Copy link
Member Author

drager commented Dec 28, 2018

@ashleygwilliams Merge conflicts should now be solved! 🎉

@ashleygwilliams
Copy link
Member

ack- i triaged in the wrong order today and looks like they are back :( i'm sorry, i'll be sure to get this in today

@drager
Copy link
Member Author

drager commented Dec 28, 2018

No worries, give me a few minutes and I will resolve them again.

@drager
Copy link
Member Author

drager commented Dec 28, 2018

Now it should be good to go.

@ashleygwilliams
Copy link
Member

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉

@drager drager deleted the refactor-binary-installation branch December 28, 2018 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor binary installation
4 participants