[DRAFT] add support for wasm32-unknown-emscripten #1469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an early draft PR for the purposes of gathering feedback early. There are also pending changes to wasm-bindgen and Emscripten. This is for issue #1468.
This PR does a few things:
wasm32-unknown-unknown
, instead reading.cargo/config.toml
to determine what the target triple is. If this file isn't present or a triple isn't specified,wasm32-unknown-unknown
is used as the default.-emscripten
, run the wasm-bindgen install step before building. This makes sure it's available for Emscripten during link time.TODOs:
-o
argument being passed to Emscripten. The default way this is set up passes a full filename ending in.wasm
, which causes Emscripten to not even attempt to emit JS. This might need a change to rustc.-o
is taken care of, actually copy the final files topkg
.