Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bindings for FocusOptions #3996

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

DanielleHuisman
Copy link
Contributor

The HTMLElement.focus() function accepts FocusOptions, but these are currently missing in web-sys. This PR adds FocusOptions and updates HTMLElement.focus() (MDN, HTML standard).

@DanielleHuisman DanielleHuisman force-pushed the feature/focus-options branch from eaadc90 to c60e495 Compare June 21, 2024 09:31
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this after a rebase!

@DanielleHuisman DanielleHuisman force-pushed the feature/focus-options branch from c60e495 to ea38d2f Compare June 24, 2024 16:05
@DanielleHuisman
Copy link
Contributor Author

Rebased :)

@daxpedda
Copy link
Collaborator

Noting that this should actually be moved to interface mixin HTMLOrSVGElement but that can be done later without a breaking change.

@daxpedda daxpedda merged commit 71bd366 into rustwasm:main Jun 24, 2024
25 checks passed
@DanielleHuisman DanielleHuisman deleted the feature/focus-options branch June 25, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants