Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JamesIves/github-pages-deploy-action in GHA workflow to newest v4 #3841

Merged

Conversation

striezel
Copy link
Contributor

@striezel striezel commented Feb 8, 2024

Updates the JamesIves/github-pages-deploy-action action used in the GitHub Actions workflow to its newest version to get rid of the related Node.js 16 deprecation warning.

Still using an older version of JamesIves/github-pages-deploy-action will generate some warning like in this run: https://github.com/rustwasm/wasm-bindgen/actions/runs/7830205111

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/download-artifact@v3, actions/upload-artifact@v3, JamesIves/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The PR will get rid of those warnings for JamesIves/github-pages-deploy-action, because v4.5.0 uses Node.js 20.

This is to get rid of the Node.js 16 deprecation warning.
@striezel striezel force-pushed the github-pages-deploy-action-v4.5.0 branch from 346373b to 6289d46 Compare February 10, 2024 22:33
@striezel striezel changed the title Update JamesIves/github-pages-deploy-action in GHA workflow to v4.5.0 Update JamesIves/github-pages-deploy-action in GHA workflow to newest v4 Feb 10, 2024
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daxpedda daxpedda merged commit 12889ef into rustwasm:main Feb 10, 2024
25 checks passed
@striezel striezel deleted the github-pages-deploy-action-v4.5.0 branch February 12, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants