Run cargo publich on deployment
#3811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liamolucko
requested changes
Jan 25, 2024
daxpedda
force-pushed
the
cargo-publish
branch
2 times, most recently
from
48ac3d0 to
bb11f4f
Compare
daxpedda
force-pushed
the
cargo-publish
branch
from
bb11f4f to
30b0a8e
Compare
daxpedda
commented
Jan 25, 2024
| - run: ./publish publish | ||
| if: startsWith(github.ref, 'refs/tags/') | ||
| env: | ||
| CARGO_REGISTRY_TOKEN: ${{ secrets.CRATES_IO_TOKEN }} |
There was a problem hiding this comment.
This was CRATES_IO_TOKEN before in bump.yml, which I think was incorrect.
I can't actually check the name of the secret, but worst case scenario we will find out when we try and publish.
Liamolucko
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately we didn't find the time to properly fix up the
bumpworkflow, so in the meantime I have opted to replace it by just runningcargo publishin the deployment step.