-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clipboard API #2100
Clipboard API #2100
Conversation
Some tests are failing because there is already a specified subset of Clipboard API in ClipboardEvent.webidl. To my understanding, it is part of the same working draft, so it should be unstable. How should I resolve this conflict? Remove old specification and keep only content of my pull request (if so in unstable or enabled?), or just ignore it? |
If it was an already-unstable API I think it's fine to delete the original WebIDL in favor of the new unstable WebIDL |
I don't understand why is the remaining test failing. It seems just like the wrong order of declarations, can I fix it somehow? |
This could perhaps be instability in the bindings generator (maybe a hash map somewhere?) or perhaps a merge that needs to happen before regenerating? |
@vojta7 You probably just have a different version of Rust, make sure your Rust is up to date ( |
@Pauan I tried your suggestions, but the generated code is still the same. |
I did also try to rebase onto the current master (last force push), but the tests are still failing. |
@vojta7 Okay, then it's probably caused by non-determinism in the bindings generator, let me take a look. |
Thank you for your time :), it did help. I also think that #1978 may have failed due to the same nondeterminism. |
Thanks! |
Adds Clipboard API (https://www.w3.org/TR/2019/WD-clipboard-apis-20190605/)
Linked issues:
#2097