Make the argument to init optional in the Typescript declaration too #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 8ace828 made the argument to the generated init() function optional (when the target is "web"), but it is still marked as required in the generated .d.ts file. Fix the generated declaration to match the function definition again.
marienz
commented
Jun 16, 2019
| @@ -396,7 +396,7 @@ impl<'a> Context<'a> { | |||
| Ok(imports) | |||
| } | |||
|
|
|||
| fn ts_for_init_fn(has_memory: bool) -> String { | |||
| fn ts_for_init_fn(has_memory: bool, has_module_or_path_optional: bool) -> String { | |||
There was a problem hiding this comment.
I'm not convinced taking a second bool flag as argument is the best interface (maybe these should be enums so it's harder to get them mixed up), but there's only one caller so maybe it's ok? If you prefer a different interface please let me know what it is and I'll change it.
(Note that I'm new to all of Rust, WebAssembly and Typescript, please don't assume I know what I'm doing :)
|
Seems reasonable to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #1579 made the argument to the generated init() function optional (when the target is "web"), but not in the .ts.d file. This brings the two back in sync.
Tested locally, using a .ts file that mostly contains the same code the "without a bundler" example includes in its index.html.