-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm-pack test fails with an error #4274
Comments
I think this is an issue with |
My project does not use serde-wasm-bindgen and also has this error breaking our CI job. That CI job previously succeeded on Oct 18, and now fails after just a Here's the GH actions job configuration up to the step that failed: runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Apply CI caching
uses: Swatinem/rust-cache@v2
- name: Install wasm-pack
run: curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh
- name: Test (WebAssembly in Node)
run: wasm-pack test --node waspiary That
... and didn't in today's build (I guess the cache entry expired), so I can't completely rule out that the actual regression occurred earlier than Oct 18 and just didn't take effect in that build (but it strikes me as unlikely). The Here's a diff of the raw Github Actions logs (skipping definitely irrelevant changes like the temp directory name and git SHA and branch name), showing the OS and Rust differences (sadly the wasm-pack version does not appear in the output): --- succeeded.txt 2024-11-22 10:17:49
+++ failed.txt 2024-11-22 10:17:59
@@ -6,9 +6,9 @@
##[endgroup]
##[group]Runner Image
Image: ubuntu-22.04
-Version: 20241015.1.0
-Included Software: https://github.com/actions/runner-images/blob/ubuntu22/20241015.1/images/ubuntu/Ubuntu2204-Readme.md
-Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20241015.1
+Version: 20241117.1.0
+Included Software: https://github.com/actions/runner-images/blob/ubuntu22/20241117.1/images/ubuntu/Ubuntu2204-Readme.md
+Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20241117.1
##[endgroup]
##[group]Runner Image Provisioner
2.0.384.1
@@ -301,13 +301,13 @@
/home/runner/.cargo
/home/runner/work/Waspiary/Waspiary/target
Restore Key:
- v0-rust-test-wasm-and-upload-pkg-0338b651
+ v0-rust-test-wasm-and-upload-pkg-1d484091
Cache Key:
- v0-rust-test-wasm-and-upload-pkg-0338b651-0d2aaad4
+ v0-rust-test-wasm-and-upload-pkg-1d484091-0d2aaad4
.. Prefix:
- v0-rust-test-wasm-and-upload-pkg
.. Environment considered:
- - Rust Version: 1.81.0 x86_64-unknown-linux-gnu (eeb90cda1969383f56a2637cbd3037bdf598841c)
+ - Rust Version: 1.82.0 x86_64-unknown-linux-gnu (f6e511eec7342f59a25f7c0534f1dbea00d01b14)
- CARGO_INCREMENTAL
.. Lockfiles considered:
- /home/runner/work/Waspiary/Waspiary/Cargo.lock ... and then the failing run compiles a bunch of things that weren't compiled in the successful run because of the caching. Then it's just:
etc., instead of the Can't reproduce locally with the same Rust version and same wasm-pack version (but I'm on an Apple Silicon Mac, so different CPU architecture). |
This went away for me when I updated my CI job to install Rust 1.81.0 with So this appears to be a regression in wasm-pack (or wasm-bindgen-test ... or Node?) introduced by Rust 1.82.0. |
This also went away for me when I tried keeping Rust 1.82.0 and instead adding: - uses: actions/setup-node@v4
with:
node-version: '22' Then also tried: steps:
- uses: actions/setup-node@v4
with:
node-version: '20' and that worked as well. Then tried: steps:
- uses: actions/setup-node@v4
with:
node-version: '18' and that fails with the Node crash, unsurprisingly because it installs the exact same version 18.20.5 of Node as is in So I've seen this So it appears that Rust 1.82.0 changes the |
Oh, and I can reproduce this locally, simply by running |
Hi, our project has the same issue; on rustc 1.81.0 the tests run fine, but they break in the same way on 1.82.0, as described in #4274 (comment) however, we don't run our tests with node but in firefox (or chrome, same issue) instead: |
temporarily fix a regression in wasm CI, see commit d41aaa9, #579, rustwasm/wasm-bindgen#4274 and rustwasm/wasm-bindgen#4274 (comment)
Got same issue in https://github.com/smartcorelib/smartcore |
If you find that your project suddenly fails when updating to Rust v1.82, see #4211 for more information. To summarize: Rust/LLVM now enable the reference type proposal by default, so your toolchain has to support that as well. |
Describe the Bug
On a side project, i update the version of wasm-bindgen to 0.2.95 and wasm-bindgen-test to 0.3.45, but when i run
wasm-pack test --target node
, the output is:Steps to Reproduce
wasm-pack test --target node -r ./geo_helper/
The link to repository with the code : repo
Cargo.toml
Exemple of a wasm-bindgen-test test of the project
Expected Behavior
In the past, when i run with wasm-bindgen version 0.2.92 and wasm-bindgen-test version 0.3.41 it works.
Actual Behavior
The command
wasm-pack test --target node
fails with the versions specified.Additional Context
The text was updated successfully, but these errors were encountered: