Do not duplicate DataCountSection and StartSection root items
#744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Any chance we can get a new release? |
|
For me it fixed the panic crash that I had with one emscripten binary, can we have a new release? seems to work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why?
it should fix #326
how?
I've taken some test code from #477 but decided to try to figure out how it was possible that an ID was repeated more than once. It turns out that for the
DataCountSectionandStartSectionwe would end up adding 2 root items that have the exact same id. I just deleted the code that did this.I think this is now correct, but I may be wrong.