Added regex functionality to the dominators sub-command. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data-pup
changed the title
fitzgen
approved these changes
May 23, 2018
opt/definitions.rs
Outdated
|
|
||
| impl Dominators { | ||
| // TODO: wasm-bindgen does not support sending Option<String> across | ||
| // the wasm ABI boundary yet. |
There was a problem hiding this comment.
It is unclear to me how this TODO is relevant? Is this copy-pasted?
There was a problem hiding this comment.
Good eye! This comment was mimicking what I saw in the implementation for Paths in that file. The comment should say: // TODO: wasm-bindgen does not support sending Vec<String> across the wasm ABI boundary yet.
I refactored the subtree member in this file from an Option<String> into a Vec<String> so that it could support multiple arguments in this commit. This was definitely a copy paste error 😬
I fixed this and squashed it into the commit, so it should be good to go now :)
data-pup
force-pushed
the
add-dominators-regex
branch
from
8738bde to
2066625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regex commands can now be given to the
dominatorssub-command :o)This required changing the
root_idmember of theDominatorTreestruct into aVec<ir::Id>collection, and some minor changes to theEmittrait logic. This generally follows the same patterns as thepathscommand, meaning that regular expressions are enabled manually using the--regexoption.Solves #59.