[Outdated] Cargo lock update #423

langyo · 2023-12-09T03:19:39Z

futursolo

Could you please add wasm-bindgen = "0.2.88" to crates/history/Cargo.toml?

Cargo.lock in gloo is not honoured if gloo-history is being referenced as a dependency in a different workspace.

langyo · 2023-12-09T05:08:20Z

Could you please add wasm-bindgen = "0.2.88" to crates/history/Cargo.toml?

Cargo.lock in gloo is not honoured if gloo-history is being referenced as a dependency in a different workspace.

Done.

futursolo · 2023-12-09T06:45:25Z

@hamza1311 Do you want to raise MSRV to 1.67?

I am fine with raising MSRV, but this is technically a breaking change, so we might have to raise the minor version.
wasm-bindgen itself does not raise the MSRV, so we can avoid increasing MSRV if we do not update all dependencies.

ranile · 2023-12-09T06:55:28Z

I'm fine with bumping the MSRV but it has to be for a good reason. What dependency needs to be bumped here?

If that will push usage of wasm-bindgen >=0.2.88, that's a good enough reason for me

futursolo · 2023-12-09T06:58:10Z

What dependency needs to be bumped here?

Raise of MSRV is side effect of cargo update. wasm-bindgen does not raise MSRV.
We only need wasm-bindgen >= 0.2.88.

langyo · 2023-12-09T07:09:01Z

I'm fine with bumping the MSRV but it has to be for a good reason. What dependency needs to be bumped here?

If that will push usage of wasm-bindgen >=0.2.88, that's a good enough reason for me

I've checked the CI log and found it finally caused by gloo-worker-macros. It depends the new version of proc-macro-crate.

ranile · 2023-12-09T09:48:45Z

Can you just update the dependencies using cargo +nightly update -Zmsrv-policy? That should update the dependencies to MSRV compatible versions. I don't want to raise the MSRV just for a proc-macro dependency, primarily because it forces the same for downstream crates.

langyo · 2023-12-09T09:51:07Z

Can you just update the dependencies using cargo +nightly update -Zmsrv-policy? That should update the dependencies to MSRV compatible versions. I don't want to raise the MSRV just for a proc-macro dependency, primarily because it forces the same for downstream crates.

Ummm...Sure

I'll try it later

ranile · 2023-12-09T09:53:18Z

I created #424 which bumps dependencies without raising MSRV

langyo · 2023-12-09T09:59:05Z

I created #424 which bumps dependencies without raising MSRV

Okay..

By the way, you reminded me that I'll be reworking the general PR on the yew later to change the MSRV part.

futursolo

@langyo

Could you please remove the MSRV changes and rebase Cargo.lock from master?

langyo · 2023-12-10T02:20:34Z

@langyo

Could you please remove the MSRV changes and rebase Cargo.lock from master?

Oh...I was made a mistake..I rolled back too far...

But since @hamza1311 has completed this part of the work..In fact, this PR is a duplicate, and it should not be a problem to turn it off.

Next I'll see how to remove the compilation macro of wasi...

cc rustwasm/gloo#423 (comment)

* Try to add wasi feature to avoid browser's ABI. * Add async render for single-threaded env. * Temporarily enable my own patch branch. It would be modified later after the corresponding library branches are merged. * add example for WASI SSR. * Ready to run WASI on wasmtime. * complete the example * fix fmt * fix fmt * I made a mistake..sry * add yew-router suites for demo * fix typo * Make the async render stream function public * Use target_os instead of feature. * Renew gloo-history's patch. * Exclude WASI example to avoid web-sys. * Try to add CI for WASI example. * Fix CI. * Fix CI that requires compiler 1.67 or newer. * Use CLI's flag instead of exclude example. bytecodealliance/wasmtime#4312 * Remove patchs. * Use LocalServerRenderer instead of ServerRenderer. yewstack/tokise#11 (comment) * Remove unused exports. * Add description about `LocalServerRenderer`. * fix fmt * fix fmt * Update Cargo.lock * Bump rust compiler's version to 1.67... * Exclude WASI on yew-router browser interfaces. * fix fmt * Wait for gloo's PR dealed. * Rollback to rust compiler 1.64. cc rustwasm/gloo#423 (comment) * Fix lock file. * Downgrade `toml_datetime` version. * Fix enum for `gloo-history`. * Well, it seems there is no way to avoid the MSRV upgrade.... * fix: Replace feature = "wasi" to target_os = "wasi". * Remove tips for rust version. * Bump `gloo` to 0.11. * Try to test yew-macro on compiler 1.67. * Try to use compiler 1.68 instead. * Try to use compiler 1.69 instead...... * Revert MSRV back * Pin the oldest Cargo.lock. * Downgrade deps for MSRV. * Bump benchmark tool's tokio to 1.35 * Try to write WASI CI. * Rollback the quotes * Combine CI files... * Rollback the use that gloo-history has fixed it. * fix * Bump gloo-history version. * Block raw html update tests on WASI. * Rollback indexmap's version. * fix CI * fix CI * Update some SSR test suites that replace ServerRender instead of LocalServerRender. * Remove yew-router's cfg macro * Fix fmt * Try to fix CI * Update examples/wasi_ssr_module/README.md Co-authored-by: Elina <[email protected]> * Revert back some unnecessary changes. * Clippy * fmt * Fix CI. * Fix CI. * Try to fix clippy. * Fix `ToString` trait. * Remove pin version of WASI CI test. * Pin the newer version. * Fix typo. * Bump `wasm-bindgen`. * Fix SSR example. * Fix typo. * Try to support non-browser environments. * Update wasm-bindgen-test to 0.3.43 refer to rustwasm/wasm-bindgen#4083 * fix doc test running on nightly * Update website/docs/advanced-topics/server-side-rendering.md Co-authored-by: WorldSEnder <[email protected]> * Update WASI CI. * Remove WASI test for rustc 1.76. * Try to let `wasmtime` CLI can be executed. * Limit the function `decode_base64` that it shouldn't runnable in non-browser environment. * Remove WASI example test for rustc 1.76. * Revert changes. * Fix CI * Fix Cargo.lock * Remove unused deps * Undo the formatting changes. * Undo the formatting changes. --------- Co-authored-by: Elina <[email protected]> Co-authored-by: Martin Molzer <[email protected]>

langyo mentioned this pull request Dec 9, 2023

Add WASI example for CI. #411

Merged

futursolo reviewed Dec 9, 2023

View reviewed changes

futursolo requested a review from ranile December 9, 2023 06:39

langyo mentioned this pull request Dec 9, 2023

Add WASI support for server-side rendering. yewstack/yew#3534

Merged

2 tasks

ranile mentioned this pull request Dec 9, 2023

Update Cargo.lock (2) #424

Merged

futursolo reviewed Dec 9, 2023

View reviewed changes

langyo closed this Dec 10, 2023

langyo force-pushed the cargo-lock-update branch from fe5cf75 to 5f96627 Compare December 10, 2023 02:17

langyo changed the title ~~Cargo lock update~~ [Outdated]Cargo lock update Dec 10, 2023

langyo changed the title ~~[Outdated]Cargo lock update~~ [Outdated] Cargo lock update Dec 10, 2023

langyo added a commit to langyo/yew that referenced this pull request Dec 10, 2023

Rollback to rust compiler 1.64.

e40fbec

cc rustwasm/gloo#423 (comment)

futursolo mentioned this pull request Dec 10, 2023

Remove the flags what to expect WASI targets. #425

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Outdated] Cargo lock update #423

[Outdated] Cargo lock update #423

langyo commented Dec 9, 2023

futursolo left a comment •

edited

Loading

langyo commented Dec 9, 2023

futursolo commented Dec 9, 2023

ranile commented Dec 9, 2023

futursolo commented Dec 9, 2023

langyo commented Dec 9, 2023

ranile commented Dec 9, 2023 •

edited

Loading

langyo commented Dec 9, 2023

ranile commented Dec 9, 2023

langyo commented Dec 9, 2023

futursolo left a comment

langyo commented Dec 10, 2023

[Outdated] Cargo lock update #423

[Outdated] Cargo lock update #423

Conversation

langyo commented Dec 9, 2023

futursolo left a comment • edited Loading

Choose a reason for hiding this comment

langyo commented Dec 9, 2023

futursolo commented Dec 9, 2023

ranile commented Dec 9, 2023

futursolo commented Dec 9, 2023

langyo commented Dec 9, 2023

ranile commented Dec 9, 2023 • edited Loading

langyo commented Dec 9, 2023

ranile commented Dec 9, 2023

langyo commented Dec 9, 2023

futursolo left a comment

Choose a reason for hiding this comment

langyo commented Dec 10, 2023

futursolo left a comment •

edited

Loading

ranile commented Dec 9, 2023 •

edited

Loading