Add soundness advisory for array-macro #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KamilaBorowska
changed the title
|
Thanks! Yeah, having this tracked sounds like a good idea for analysis purposes. I know some folks are looking through the advisories to get a feel for what kind of vulnerabilities even exist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat ancient unsoundness issue (like, one that was fixed 20 months ago), but may as well report it, even if really nobody will care. It may have some educational value however - somebody may see this issue and realize there is a similar issue in macros they wrote. See rust-lang/unsafe-code-guidelines#278 for more context.