Allow special characters in DB connection parts #386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Addresses #383, tests based on #384.
This approach uses
urllib.prase.quote()
to handle special characters in Postgres passwords and other conn string components. This allows continuing to use URI style connection strings. There are a variety of places throughout the code that expect URI style connections.The
quote()
method appears to handle the requirements defined by Postgres.Thank you @jmealo for all the sleuthing you did to determine the cause of the issue and suggesting a path forward! I'll get an updated
:latest
image pushed soon, will comment here when that's ready.