Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code restructuring, cleanup, tests #206

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Code restructuring, cleanup, tests #206

merged 2 commits into from
Nov 24, 2021

Conversation

rustprooflabs
Copy link
Owner

@rustprooflabs rustprooflabs commented Nov 23, 2021 •
edited
Loading

Details

Progresses #193. Code cleanup and unit tests.

  • Moves Geofabrik file handling code to dedicated module
  • Moves date and md5 validation to new helpers.py (sets stage to allow validation w/ --input-file)
  • Additional unit tests
  • make outputs coverage report after running unit tests

@rustprooflabs rustprooflabs added the Technical Debt Not broken, not new, but not right either! label Nov 23, 2021
@rustprooflabs rustprooflabs added this to the 0.4.2 milestone Nov 23, 2021
@rustprooflabs
Copy link
Owner Author

Migrates code to tackle of item 1 in #186 (comment).

@rustprooflabs rustprooflabs merged commit 35fcdf3 into main Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Technical Debt Not broken, not new, but not right either!
Projects
None yet
Milestone
0.4.2
Development

Successfully merging this pull request may close these issues.
1 participant
@rustprooflabs