Improve usability around region/subregion #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to explain the nuance. #198
…on, split validations out to function.
|
Created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reported in #198 can't be resolved by improving the file name handling, at least not easily. The issue stems from the decision to tightly couple to Geofabrik's download server. This PR raises an error when a slash is detected in the region name and subregion is none, in these cases the portion after the last
/should be in the subregion.This also updates the documentation to add a section about the region/subregion, and show this example. I'm sure there's room for improvement in the wording, this is a quick start to improve this.