Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace _all views with tables build using centroid() #320

Closed
rustprooflabs opened this issue May 7, 2023 · 1 comment · Fixed by #337
Closed

Replace _all views with tables build using centroid() #320

rustprooflabs opened this issue May 7, 2023 · 1 comment · Fixed by #337
Labels
breaking Breaking change Technical Debt Not broken, not new, but not right either!
Milestone
0.9.0

Comments

@rustprooflabs
Copy link
Owner

Details

⚠️ This will be a breaking change. ⚠️

The three "all" views will be removed in favor of building tables during import. Since osm2pgsql 1.7.1 there is a centroid() option that should remove the need for these views:

  • osm.vbuilding_all
  • osm.vpoi_all
  • osm.vshop_all

See: https://osm2pgsql.org/doc/manual.html#geometry-objects-in-lua
@rustprooflabs rustprooflabs added Technical Debt Not broken, not new, but not right either! breaking Breaking change labels May 7, 2023
@rustprooflabs rustprooflabs added this to the 0.9.0 milestone May 7, 2023
@rustprooflabs rustprooflabs mentioned this issue Jun 4, 2023
Merged
@rustprooflabs
Copy link
Owner Author

Available to test from the dev image.

docker pull rustprooflabs/pgosm-flex:dev

rustprooflabs added a commit that referenced this issue Jun 11, 2023
@rustprooflabs
Cleanup RE #320 (#340)
503bad7 
* Remove refresh of MV that no longer exists. Make comments on new tables more consistent

* Add missing comments. Install PgDD extension
rustprooflabs added a commit that referenced this issue Jun 11, 2023
@rustprooflabs
Merge changes - switch from all views to tables via centroid (#341)
3b505eb 
* Add shop tests (#338)

Add tests for shop point/polygon counts. Includes moving test docs to main docs page, and overall improvements to the examples.

* Change "all" views to tables loaded via Flex style (#337)

* Changing vbuilding_all view to building_combined_point table

* Create PK, move helper into style folder

* Starting to convert vshop_all. Current version has test errors due to moving code into shop_helper. Need to add more tests on original to help find the cause of the problem with this change.

* Fix loading of shop polygons. Reset shop_polygon test output to actual.

* Add detailed POI tests

* Restructure POI loading in prep to migrate all view

* Moving from vpoi_all mat view to poi_combined_point table

* still failing on poi_combined_point

* Fixed import problem by setting up ID column properly

* Cleanup RE #320 (#340)

* Remove refresh of MV that no longer exists. Make comments on new tables more consistent

* Add missing comments. Install PgDD extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Breaking change Technical Debt Not broken, not new, but not right either!
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

Change "all" views to tables loaded via Flex style rustprooflabs/pgosm-flex
1 participant
@rustprooflabs