Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Road polygon ref missing comment #210

Closed
rustprooflabs opened this issue Nov 29, 2021 · 1 comment
Closed

Road polygon ref missing comment #210

rustprooflabs opened this issue Nov 29, 2021 · 1 comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone

Comments

@rustprooflabs
Copy link
Owner

What version of PgOSM Flex are you using?

Noticed in v0.3.3 data, verified still present in main branch.

What did you do exactly?

Using PgDD looking at ref column I noticed the osm.road_polygon is missing a description.

SELECT s_name, source_type, t_name, c_name, data_type, description
    FROM dd.columns
    WHERE c_name = 'ref'
         AND s_name = 'osm'
;
┌────────┬─────────────┬────────────────────────┬────────┬───────────┬─────────────────────────────────────────────┐
│ s_name │ source_type │         t_name         │ c_name │ data_type │                 description                 │
╞════════╪═════════════╪════════════════════════╪════════╪═══════════╪═════════════════════════════════════════════╡
│ osm    │ table       │ public_transport_line  │ ref    │ text      │ Reference number or code. Best ref option d…│
│        │             │                        │        │           │…etermined by helpers.get_ref(). https://wik…│
│        │             │                        │        │           │…i.openstreetmap.org/wiki/Key:ref            │
│ osm    │ table       │ public_transport_point │ ref    │ text      │ Reference number or code. Best ref option d…│
│        │             │                        │        │           │…etermined by helpers.get_ref(). https://wik…│
│        │             │                        │        │           │…i.openstreetmap.org/wiki/Key:ref            │
│ osm    │ table       │ public_transport_polyg…│ ref    │ text      │ Reference number or code. Best ref option d…│
│        │             │…on                     │        │           │…etermined by helpers.get_ref(). https://wik…│
│        │             │                        │        │           │…i.openstreetmap.org/wiki/Key:ref            │
│ osm    │ table       │ road_line              │ ref    │ text      │ Reference number or code. Best ref option d…│
│        │             │                        │        │           │…etermined by helpers.get_ref(). https://wik…│
│        │             │                        │        │           │…i.openstreetmap.org/wiki/Key:ref            │
│ osm    │ table       │ road_point             │ ref    │ text      │ Reference number or code. Best ref option d…│
│        │             │                        │        │           │…etermined by helpers.get_ref(). https://wik…│
│        │             │                        │        │           │…i.openstreetmap.org/wiki/Key:ref            │
│ osm    │ table       │ road_polygon           │ ref    │ text      │ ¤                                           │
└────────┴─────────────┴────────────────────────┴────────┴───────────┴─────────────────────────────────────────────┘

To fix

Verified this is missing in /flex-config/sql/road.sql. Add the missing comment.

@rustprooflabs rustprooflabs added bug Something isn't working documentation Improvements or additions to documentation labels Nov 29, 2021
@rustprooflabs rustprooflabs added this to the 0.4.2 milestone Nov 29, 2021
@rustprooflabs
Copy link
Owner Author

Closed via #213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant