Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region to sub-region in output filenames #131

Closed
rustprooflabs opened this issue May 18, 2021 · 2 comments · Fixed by #136
Closed

Add region to sub-region in output filenames #131

rustprooflabs opened this issue May 18, 2021 · 2 comments · Fixed by #136
Labels
Docker Docker image and/or related script(s) Technical Debt Not broken, not new, but not right either!
Milestone

Comments

@rustprooflabs
Copy link
Owner

Example of the output filename: pgosm-flex-district-of-columbia-run-all.sql

Fine for D.C., but Georgia (in U.S.) is not Georgia (in Europe).

@rustprooflabs rustprooflabs added the Technical Debt Not broken, not new, but not right either! label May 18, 2021
@rustprooflabs rustprooflabs added the Docker Docker image and/or related script(s) label May 26, 2021
@rustprooflabs
Copy link
Owner Author

rustprooflabs commented May 26, 2021

UPDATE: The idea in this comment is captured in #135.


The Docker script currently has a region param and a sub-region param. Should combined them into a single param. This will simplify use by not having an arbitrary difference between a "region" and "subregion".

This would change:

docker exec -it \
    -e POSTGRES_PASSWORD=mysecretpassword \
    -e POSTGRES_USER=postgres \
    pgosm bash docker/run_pgosm_flex.sh \
    north-america/us \
    district-of-columbia \
    8 \
    run-all

TO

docker exec -it \
    -e POSTGRES_PASSWORD=mysecretpassword \
    -e POSTGRES_USER=postgres \
    pgosm bash docker/run_pgosm_flex.sh \
    north-america/us/district-of-columbia \
    8 \
    run-all

Should add a check to script to catch when 4 params are passed and advise the user about the change to 3 params.

e.g. https://stackoverflow.com/questions/18568706/check-number-of-arguments-passed-to-a-bash-script

@rustprooflabs rustprooflabs modified the milestones: 0.2.1, 0.2.0 May 26, 2021
@rustprooflabs rustprooflabs changed the title Add region to sub-region in filenames Add region to sub-region in output filenames May 28, 2021
@rustprooflabs rustprooflabs modified the milestones: 0.2.1, 0.2.2 Jul 11, 2021
@rustprooflabs
Copy link
Owner Author

Added via #147.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker Docker image and/or related script(s) Technical Debt Not broken, not new, but not right either!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant