Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variety of bench values breaking amenity not null in osm_type #119

Closed
rustprooflabs opened this issue Apr 30, 2021 · 3 comments · Fixed by #120
Closed

Variety of bench values breaking amenity not null in osm_type #119

rustprooflabs opened this issue Apr 30, 2021 · 3 comments · Fixed by #120
Labels
bug Something isn't working
Milestone

Comments

@rustprooflabs
Copy link
Owner

Details

Caused by #110.

Two records discovered, one bench=unknown the other bench=picnic_table...

Should be able to resolve by changing this

    if object.tags.bench == 'no' then
        return
    end

to

    if object.tags.bench ~= 'yes' then
        return
    end

The only valid values described are yes/no so discarding other values is fine.

@rustprooflabs rustprooflabs added the bug Something isn't working label Apr 30, 2021
@rustprooflabs rustprooflabs added this to the 0.1.6 milestone Apr 30, 2021
@jacopofar
Copy link
Contributor

jacopofar commented May 1, 2021

Amazing, I came here to report this bug but I see you already found it :)

I detected it on these nodes:

@rustprooflabs
Copy link
Owner Author

I didn't log it very long before you ended up here! I particularly like bench=no;yes in two of those examples. 🥇

This should be fixed soon!

@rustprooflabs
Copy link
Owner Author

@jacopofar This should be fixed in main now, the new :latest Docker image will be available shortly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants