Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.7.1 #113

Merged
merged 8 commits into from
Jul 3, 2024
Merged

Prepare 0.7.1 #113

merged 8 commits into from
Jul 3, 2024

Conversation

djc
Copy link
Member

@djc djc commented Jul 2, 2024

Proposed release notes

  • Include certificates from the SSL_CERT_DIR environment variable and openssl-probe ProbeResult::cert_dir in the set of returned certificates. This should improve results on FreeBSD (in case the ca_root_nss package is not installed).

Some follow-up from #109 and a version bump for 0.7.1.

@djc djc force-pushed the prepare-0.7.1 branch from c66d1ef to 264601f Compare July 2, 2024 10:11
@djc djc force-pushed the prepare-0.7.1 branch from 264601f to 9973360 Compare July 2, 2024 10:21
@cpu
Copy link
Member

cpu commented Jul 2, 2024

Only one PR to call out in the changelog

Can you propose some release notes describing 109?

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djc
Copy link
Member Author

djc commented Jul 3, 2024

Added proposed release notes.

@cpu
Copy link
Member

cpu commented Jul 3, 2024

Release notes look good. Thank you

@djc djc added this pull request to the merge queue Jul 3, 2024
Merged via the queue into main with commit 5292c99 Jul 3, 2024
28 checks passed
@djc djc deleted the prepare-0.7.1 branch July 3, 2024 13:17
@djc
Copy link
Member Author

djc commented Jul 3, 2024

  • Published rustls-native-certs v0.7.1 at registry crates-io
  • [new tag] v/0.7.1 -> v/0.7.1
  • Published release notes

@StackOverflowExcept1on
Copy link

StackOverflowExcept1on commented Jul 8, 2024

Now I have a problem with reqwest crate which cannot find certificates in Ubuntu 22.04 LTS when using reqwest::Client::builder(): https://github.com/foundry-rs/foundry/blob/8b694bbcabaedffc0337bf8dea9a135da5694ef9/crates/common/src/selectors.rs#L43. By default SSL_CERT_DIR and SSL_CERT_FILE are not set in Ubuntu.

This started after a dependency dump: foundry-rs/foundry@8b694bb

    Updating rustls-native-certs v0.7.0 -> v0.7.1
    Updating rustls-webpki v0.102.4 -> v0.102.5

@djc
Copy link
Member Author

djc commented Jul 8, 2024

@StackOverflowExcept1on please file a new issue?

@StackOverflowExcept1on
Copy link

@djc I don't know how to reproduce this outside the foundry

@djc
Copy link
Member Author

djc commented Jul 9, 2024

Just file the new issue, we can look into it even if you have no reproduction path yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants