Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acceptor: fix nightly doc_overindented_list_items warns #534

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

cpu
Copy link
Member

@cpu cpu commented Feb 5, 2025

Of the form:

warning: doc list item overindented
   --> librustls/src/acceptor.rs:219:9
    |
219 |     ///      with rustls_accepted_into_connection.
    |         ^^^^^ help: try using `   ` (3 spaces)
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
    = note: `#[warn(clippy::doc_overindented_list_items)]` on by default

Nightly clippy has been emitting these on main since ~today.

@cpu cpu self-assigned this Feb 5, 2025
Of the form:
```
warning: doc list item overindented
   --> librustls/src/acceptor.rs:219:9
    |
219 |     ///      with rustls_accepted_into_connection.
    |         ^^^^^ help: try using `   ` (3 spaces)
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
    = note: `#[warn(clippy::doc_overindented_list_items)]` on by default
```
@cpu cpu force-pushed the cpu-nightly-clippy-fixes branch from b3be21b to 3c9e20c Compare February 5, 2025 14:20
@cpu
Copy link
Member Author

cpu commented Feb 5, 2025

Heh, fun Windows CI flake from curl/schannel:

curl -L "$env:LINK/$env:CARGO_C_FILE" -o cargo-c-windows-msvc.zip
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (35) schannel: next InitializeSecurityContext failed: CRYPT_E_REVOCATION_OFFLINE (0x80092013) - The revocation function was unable to check revocation because the revocation server was offline.

Guessing that's OCSP? 🤷

@ctz
Copy link
Member

ctz commented Feb 5, 2025

Guessing that's OCSP? 🤷

😂

@cpu cpu merged commit 0743cb1 into rustls:main Feb 5, 2025
45 checks passed
@cpu cpu deleted the cpu-nightly-clippy-fixes branch February 5, 2025 14:54
@icing
Copy link
Collaborator

icing commented Feb 5, 2025

Yeah, Schannel is quite an amusing backend.💁🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants