Migrate to pki-types PEM decoder #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The job that the rustls-pemfile crate was doing has now been folded into the pki-types crate where we can offer a more integrated experience (and also avoid timing side-channels in base64 decoding of private key material). This branch replaces rustls-ffi's usage of rustls-pemfile with pki-types >1.10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The job that the rustls-pemfile crate was doing has now been folded into the pki-types crate where we can offer a more integrated experience (and also avoid timing side-channels in base64 decoding of private key material).
This branch replaces rustls-ffi's usage of rustls-pemfile with pki-types >1.10. Happily a lot of extra helper code/imports fall away 🚀
Resolves #475
See also rustls/rustls#2140