tests: fix clippy::zombie_processes finding #467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly clippy's
clippy::zombie_processes
lint flagged the following:While we do call
kill()
on the process, we weren'twait()
ing it. Theprocess::Child
docs have a warning:So it seems it may not be sufficient on all systems to
kill()
withoutwait()
.Let's add a
wait()
just to be sure. Nobody likes zombies.