Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Don't panic when reading empty files #381

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

aawsome
Copy link
Member

@aawsome aawsome commented Dec 6, 2024

There was a bug when using partition_point which in that case does not gave guarentees about its behavior. Hence the whole logic was refactored and unit/integration tests were added.

closes rustic-rs/rustic#1380

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 67.74194% with 10 lines in your changes missing coverage. Please review.

Project coverage is 42.2%. Comparing base (bf6c7d0) to head (28e7968).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/vfs.rs 66.6% 10 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/core/src/repository.rs 42.2% <100.0%> (ø)
crates/core/tests/integration.rs 84.6% <ø> (+3.8%) ⬆️
crates/core/src/vfs.rs 16.9% <66.6%> (+6.1%) ⬆️

... and 18 files with indirect coverage changes

@aawsome aawsome changed the title fix: Don't panic when reading empty files fix!: Don't panic when reading empty files Dec 10, 2024
@aawsome aawsome added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 70bc278 Dec 11, 2024
27 checks passed
@aawsome aawsome deleted the fix-read-emptyfile branch December 11, 2024 00:10
@rustic-release-plz rustic-release-plz bot mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when dumping tar.gz or tar format from snapshot
2 participants