Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: opendal paths on windows #340

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix: opendal paths on windows #340

merged 1 commit into from
Oct 24, 2024

Conversation

aawsome
Copy link
Member

@aawsome aawsome commented Oct 24, 2024

We now always use UnixPaths to generate the path used in opendal URLs.

closes rustic-rs/rustic#1162
closes rustic-rs/rustic#1302
closes rustic-rs/rustic#1305

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.4%. Comparing base (996a10f) to head (d993993).
Report is 1 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
crates/backend/src/opendal.rs 90.6% <ø> (ø)

... and 3 files with indirect coverage changes

@simonsan simonsan added this pull request to the merge queue Oct 24, 2024
@simonsan simonsan added C-bug Category: Something isn't working as expected O-windows Operating system: Windows A-backends Area: Related to backends in rustic_core labels Oct 24, 2024
@simonsan simonsan changed the title fix: fix opendal paths on windows fix: opendal paths on windows Oct 24, 2024
Merged via the queue into main with commit b29f203 Oct 24, 2024
33 checks passed
@simonsan simonsan deleted the fix-opendal-windows branch October 24, 2024 15:32
@rustic-release-plz rustic-release-plz bot mentioned this pull request Oct 24, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2024
## 🤖 New release
* `rustic_backend`: 0.4.1 -> 0.4.2 (✓ API compatible changes)
* `rustic_core`: 0.5.3 -> 0.5.4 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `rustic_backend`
<blockquote>

##
[0.4.2](rustic_backend-v0.4.1...rustic_backend-v0.4.2)
- 2024-10-24

### Fixed

- fix opendal paths on windows
([#340](#340))
</blockquote>

## `rustic_core`
<blockquote>

##
[0.5.4](rustic_core-v0.5.3...rustic_core-v0.5.4)
- 2024-10-24

### Added

- *(commands)* Add convenient names for read-data-subset n/m
([#328](#328))

### Fixed

- OpenFile::read_at no longer errors on invalid offset or length
([#331](#331))

### Other

- *(deps)* update actions
([#338](#338))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backends Area: Related to backends in rustic_core C-bug Category: Something isn't working as expected O-windows Operating system: Windows
Projects
None yet
2 participants