fix(deps): update rustic_core and other dependencies and fix merge precedence #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking Change: Due to changes in the way how merging of values is applied to configuration values in BackendOptions this should be considered a breaking change. Please make sure, your workflow is still working as intended, especially that the configuration is applied as you wanted it. Signed-off-by: simonsan <[email protected]>
simonsan
added
M-breaking
Signed-off-by: simonsan <[email protected]>
Signed-off-by: simonsan <[email protected]>
Signed-off-by: simonsan <[email protected]>
|
|
|
IMO this is not breaking |
aawsome
reviewed
Oct 2, 2024
simonsan
changed the title
simonsan
changed the title
aawsome
removed
M-breaking
simonsan
commented
Oct 2, 2024
This was referenced Oct 2, 2024
Closed
Merged
simonsan
added a commit
that referenced
this pull request
Oct 2, 2024
…ecedence (#1282) Due to changes in the way how merging of values were applied to configuration values in `BackendOptions` this should is considered a fix. Now values from the configuration file don't overwrite values from environment variables, any more. As it was intended and stated in the documentation. Please make sure, your workflow is still working as intended, especially that the configuration values and environment variables are applied as you wanted it and as we documented it in the Configuration documentation. Precedence also applies when inheriting options from other profiles using `use-profiles` or when using multiple profiles, e.g. `rustic -P one -P two`. If the same repository option is defined in `one` and `two` the value of `one` is taken. Before the fix, the value of `two` was taken. But the fix only applies to the repository options. For other options, `one` always had precedence. Fixes #1226 --------- Signed-off-by: simonsan <[email protected]> Co-authored-by: Alexander Weiss <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
## 🤖 New release * `rustic-rs`: 0.9.0 -> 0.9.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.9.1](v0.9.0...v0.9.1) - 2024-10-03 ### Added - *(config)* add more filters ([#1263](#1263)) - *(check)* Allow to only check trees+packs for given snapshots ([#1230](#1230)) - *(commands)* add a `docs` command to easily access the user, dev and config documentation ([#1276](#1276)) ### Fixed - *(docs/cli)* improve the descriptions of the CLI commands ([#1277](#1277)) - *(deps)* update rustic_core and other dependencies and fix merge precedence ([#1282](#1282)) - *(docs)* update configuration documentation to align with recent changes ([#1280](#1280)) ### Other - *(deps)* upgrade dependencies ([#1289](#1289)) - add triage label to new issues only if no label has been set when creating it ([#1287](#1287)) - *(interactive)* use update methods for refreshing snapshots ([#1285](#1285)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes in the way how merging of values were applied to configuration values in
BackendOptionsthis should is considered a fix. Now values from the configuration file don't overwrite values from environment variables, any more. As it was intended and stated in the documentation.Please make sure, your workflow is still working as intended, especially that the configuration values and environment variables are applied as you wanted it and as we documented it in the Configuration documentation.
Precedence also applies when inheriting options from other profiles using
use-profilesor when using multiple profiles, e.g.rustic -P one -P two. If the same repository option is defined inoneandtwothe value ofoneis taken. Before the fix, the value oftwowas taken. But the fix only applies to the repository options. For other options,onealways had precedence.Fixes #1226