Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Allow specifying many options in config profile without array #1130

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

aawsome
Copy link
Member

@aawsome aawsome commented Apr 22, 2024

Breaking change:
password-command and warmup-command now must be given as array if the commands use args.

Copy link
Member Author

@aawsome aawsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aawsome aawsome merged commit 58ed4b3 into main Apr 22, 2024
28 checks passed
@aawsome aawsome deleted the oneormany branch April 22, 2024 13:03
@intgr
Copy link
Contributor

intgr commented Aug 19, 2024

password-command and warmup-command now must be given as array if the commands use args.

To be honest, I think this is slightly annoying. I can no longer copy-paste the command directly into a shell to test that it works.

@aawsome
Copy link
Member Author

aawsome commented Aug 30, 2024

To be honest, I think this is slightly annoying. I can no longer copy-paste the command directly into a shell to test that it works.

@intgr I got your point. So maybe we should allow both: a single string which would be automatically split into its parts and an array to cover complicated spacing.... I'll discuss this with the other maintainers..

@aawsome
Copy link
Member Author

aawsome commented Aug 31, 2024

@intgr After a short discussion we decided that we want to support a single string. So this change will be kind of reverted/overworked.

@thePanz
Copy link

thePanz commented Sep 12, 2024

Thanks for working in supporting the single string configuration for "password-command" again.

Would be great to also include a more clear message when the failure related to that configuration change is triggered.

Example: I still had the "old" configuration with password-command = "secret-tool lookup ...", which now it gives just a single line of error like when running rustic:

error: No such file or directory (os error 2)

It took a while to identify where the error was triggered, and the "no such file" was quite misleading 🤯
Adding some context on the error might help

@intgr
Copy link
Contributor

intgr commented Sep 12, 2024

It took a while to identify where the error was triggered, and the "no such file" was quite misleading 🤯

I also experienced this and submitted a PR to improve the situation: rustic-rs/rustic_core#265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants