This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
fix(metal): patch ggml-metal.m with shader code #328
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate fix to #324 (thanks for the inspiration!)
The Rust build script has the ability to create new files, and use them as fodder for the build process. We can use this to create an alternate
ggml-metal.m
that embeds the Metal shader source code and sidestep the issue of runtime loading entirely.Let me know if you're OK with this @pixelspark @nightscape !