This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
Made Sampler and InferenceParameters threadsafe #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philpax
reviewed
Jun 2, 2023
| @@ -85,6 +85,11 @@ pub struct InferenceParameters { | |||
| /// sampler that offers a [Default](samplers::TopPTopK::default) implementation. | |||
| pub sampler: Arc<dyn Sampler>, | |||
| } | |||
|
|
|||
| //Since Sampler implements Send and Sync, InferenceParameters should too. | |||
| unsafe impl Send for InferenceParameters {} | |||
There was a problem hiding this comment.
hol up is this necessary? won't these be inherited?
There was a problem hiding this comment.
(it's fine but I don't think it's needed?)
There was a problem hiding this comment.
PyO3 was complaining, so i had to wrap it in an Arc<>. With this i can just use it in a python objekt.
There was a problem hiding this comment.
weird, I think it should automatically infer Send + Sync for inference parameters as all the fields should be, too 🤔
It's totally fine as is, but can you try playing around with it and see if it still compiles without the unsafe impls?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.