This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
Add alternative key shortcuts for shift enter #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, but I can't test it right now. Will try to get back to you soon! |
|
Thanks for the PR! Much appreciated :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #157 shift enter is not working. This PR follows the example in amazon qldb shell https://github.com/awslabs/amazon-qldb-shell/blob/main/src/ui.rs#L162 to support Option + enter on mac (and shift enter on windows).
I got a lot of help from Bard to write this PR as I don't actually know Rust, but when I compiled it, it seems to work on my mac for option + enter to insert new lines. If someone could test on Windows that would be great. If it doesn't work on Windows, another option I've seen used is Shift + Down to insert a new line.