Skip to content
This repository was archived by the owner on Jun 24, 2024. It is now read-only.

README updates for v0.2 #253

Merged
merged 4 commits into from
May 20, 2023
Merged

Conversation

danforbes
Copy link
Contributor

@danforbes danforbes commented May 20, 2023

@@ -28,51 +35,53 @@ to support GPU inference in the future through alternate backends.

Currently, the following models are supported:

- [BLOOM](https://huggingface.co/docs/transformers/model_doc/bloom)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we list some interesting examples of these? BLOOM has BLOOMZ, GPT-J has GPT4All, etc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this request.

Copy link
Collaborator

@philpax philpax May 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the README has

Currently, the following models are supported:

where GPT-NeoX and LLaMA have some examples of models that use those architectures. It would be nice to have some examples for BLOOM, GPT-2, GPT-J and MPT too (even if it's just "MPT" for the last one), just so that it doesn't look weirdly imbalanced.

Those models could also have links to the descriptions (e.g. linking Alpaca to the Stanford article), but I leave that up to you.

Copy link
Collaborator

@philpax philpax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much good to go, just those last two things. Once they're sorted I'll merge

@philpax philpax merged commit 653de81 into rustformers:main May 20, 2023
@danforbes danforbes deleted the dfo/docs/readme branch May 20, 2023 22:45
@hhamud hhamud mentioned this pull request Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants