This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 369
Implement LoRA patching via the Loader #211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alright the output is now correct (at least not gibberish anymore). I just moved the memory regions correctly and its working now. |
Will look at soon! Can you mention what you tested with, and make Clippy happy? |
Sure i used this Alpaca adapter and this LLama base model. |
Maybe the vicuna-chat should be removed from the examples 🤔 |
That'd be a question for @danforbes 🤔 What would be your reasoning for removing it? |
Its fine, just had a brain-lag. Thought i was another inference example but its an actual chat implementation.😅 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to apply a LoRA adapter while loading the model. The adapter can be defined via the optional
lora_adapter
field inModelParameters
.The patches are then lazily applied while the tensors are loaded via the
MmapCompatibleLoader
.This currently produces garbled outputs. Probably because the weights aren't copied correctly from the
patched_tensor
to thebase_tensor
.Currently the weights are moved by setting the tensor data directly, this probably doesn't work as i expected it to.
To use a LoRA adapter via the cli simply add a
--lora-path
flag.Example:
llama infer --model-path "path\to\model" --lora-path "path\to\adapter" -p "The meaning of life is"