Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

Fine-grain inference feedback #206

Merged
merged 4 commits into from
May 11, 2023

Conversation

danforbes
Copy link
Contributor

Related to #151 and #205

@danforbes
Copy link
Contributor Author

Just realized I never actually implemented Halt on the InferenceSession side 😅

@danforbes
Copy link
Contributor Author

I'm not able to see why the job is failing
image

@philpax
Copy link
Collaborator

philpax commented May 10, 2023

This looks good to me from a glance, but I'll need to pull it down locally and play around with it. Will try to get to it soon 🚀

@danforbes danforbes force-pushed the dfo/refactor/inference-callback branch 5 times, most recently from cc14b54 to 32768d8 Compare May 11, 2023 20:07
Copy link
Collaborator

@philpax philpax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from that one quibble.

@philpax philpax merged commit 913875a into rustformers:main May 11, 2023
@danforbes danforbes deleted the dfo/refactor/inference-callback branch May 11, 2023 23:16
@danforbes danforbes mentioned this pull request May 11, 2023
@hhamud hhamud mentioned this pull request Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants