Skip to content

Commit

Permalink
Merge branch 'master' into maybe-uninit
Browse files Browse the repository at this point in the history
  • Loading branch information
scrogson authored Oct 13, 2019
2 parents 8906fb4 + afda9b8 commit 23ef1ed
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 6 deletions.
9 changes: 8 additions & 1 deletion rustler/src/resource.rs
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,14 @@ pub fn open_struct_resource_type<'a, T: ResourceTypeProvider>(
)
};

res.map(|r| ResourceType { res: r, struct_type: PhantomData})
if let Some(res) = res {

This comment has been minimized.

Copy link
@evnu

evnu Oct 13, 2019

Member

Out of curiosity: why not use map here?

This comment has been minimized.

Copy link
@filmor

filmor Oct 13, 2019

Member

This comment has been minimized.

Copy link
@scrogson

scrogson Oct 14, 2019

Author Member

Oh, did I mess up the conflict?

Some(ResourceType {
res,
struct_type: PhantomData,
})
} else {
None
}
}

fn get_alloc_size_struct<T>() -> usize {
Expand Down
2 changes: 0 additions & 2 deletions rustler_codegen/src/ex_struct.rs
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,6 @@ pub fn gen_decoder(
let gen = quote! {
impl<'a> ::rustler::Decoder<'a> for #struct_type {
fn decode(term: ::rustler::Term<'a>) -> Result<Self, ::rustler::Error> {
use ::rustler::Encoder;

#atom_defs

let env = term.get_env();
Expand Down
1 change: 0 additions & 1 deletion rustler_codegen/src/record.rs
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ pub fn gen_encoder(
fn encode<'a>(&self, env: ::rustler::Env<'a>) -> ::rustler::Term<'a> {
#atom_defs

use ::rustler::Encoder;
let arr = #field_list_ast;
::rustler::types::tuple::make_tuple(env, &arr)
}
Expand Down
1 change: 0 additions & 1 deletion rustler_codegen/src/tuple.rs
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ pub fn gen_encoder(
let gen = quote! {
impl<'b> ::rustler::Encoder for #struct_typ {
fn encode<'a>(&self, env: ::rustler::Env<'a>) -> ::rustler::Term<'a> {
use ::rustler::Encoder;
let arr = #field_list_ast;
::rustler::types::tuple::make_tuple(env, &arr)
}
Expand Down
2 changes: 1 addition & 1 deletion rustler_sys/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ build = "build.rs"
categories = ["external-ffi-bindings"]

[dependencies]
unreachable = "0.1"
unreachable = "1.0"

0 comments on commit 23ef1ed

Please sign in to comment.