Discard mouse down after Cocoa window resize #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are sending the mouse down event after the window resize has completed, because Cocoa uses a modal event loop to implement window resize. This leads to a mouse down without a matching mouse up.
|
Very nice. I've also confirmed that it fixes the referenced Alacritty problem. It would be nice to have a comment or two added explaining what the discarding is for, though. In addition to that, a CHANGELOG entry can't hurt. |
Add some explanatory comments and a changelog entry.
|
Thanks! |
francesca64
added a commit
that referenced
this pull request
Apr 18, 2018
This reverts commit 19cd531.
francesca64
added a commit
that referenced
this pull request
Apr 18, 2018
tmfink
pushed a commit
to tmfink/winit
that referenced
this pull request
Jan 5, 2022
Update canvas_nanovg example The `canvas_nanovg` example would not run on my Linux machine due to the bug in `winit` 0.19 (rust-windowing#1773) In this PR, I updated `winit` and `surfman` and made the minimum necessary changes so that the example would compile and run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are sending the mouse down event after the window resize has
completed, because Cocoa uses a modal event loop to implement window
resize. This leads to a mouse down without a matching mouse up.
This fixes #463.